Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

REFACTOR update carousel class to fs-carousel #177

Merged
merged 1 commit into from
May 23, 2019

Conversation

muskie9
Copy link
Member

@muskie9 muskie9 commented May 17, 2019

resolves #139

This updates .carousel css class references to .fs-carousel to prevent collisions with other carousel tools

@muskie9 muskie9 added the v4 label May 17, 2019
@muskie9 muskie9 added this to the 4.0.0 milestone May 17, 2019
@muskie9 muskie9 requested a review from korthjp17 May 17, 2019 16:03
@codecov
Copy link

codecov bot commented May 17, 2019

Codecov Report

Merging #177 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #177   +/-   ##
=========================================
  Coverage     49.83%   49.83%           
  Complexity       90       90           
=========================================
  Files             6        6           
  Lines           295      295           
=========================================
  Hits            147      147           
  Misses          148      148
Impacted Files Coverage Δ Complexity Δ
src/ORM/FlexSlider.php 68.26% <0%> (ø) 21 <0> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0767afb...f3562a0. Read the comment docs.

@muskie9 muskie9 force-pushed the pull/carouselClass#139 branch from f639708 to f3562a0 Compare May 23, 2019 19:05
@muskie9
Copy link
Member Author

muskie9 commented May 23, 2019

Updated css to match new class reference.

@muskie9 muskie9 merged commit 9136226 into dynamic:master May 23, 2019
@muskie9 muskie9 deleted the pull/carouselClass#139 branch May 23, 2019 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant